KProcessRunner: only emit processStarted() signal once (!299) · Merge requests · Frameworks / KIO

Ahmad Samir requested to merge work/ahmad/kprocessrunner into master Jan 04, 2021

As discussed with dfaure on IRC, processStarted() signal should only be emitted once from setPid(). In this code "!m_pid" is used as "this hasn't been run before" condition.

This fixes a crash in applicationlauncherjob_servicetest, which incidentally passes on the CI and when using kdesrc-build; for the crash to happen systemd needs to be actually running/used by KProcessRunner.

This reverts commit aa4e0645.

KProcessRunner: only emit processStarted() signal once

Merge request reports