Skip to content

[KFilePlacesItem] Avoid calling KMountPoint::findByPath()

Kai Uwe Broulik requested to merge work/kbroulik/kfileplaces-kdeconnect into master

It resolves symlinks, potentially blocking, when KDE Connect device is unreachable, and isn't needed here as we know we query for an existing actual mount point.

Noticed that my Plasma froze unexpectedly while doing some KDE Connect file copying, found in the backtrace it was KFilePlacesItem as the notification job description uses KFilePlacesModel to prettify the shown location. Might also explain the random occasional longer-than-usual startup times of Dolphin I'm experiencing.

  • KDE Connect device is still properly hidden

Using KMountPoint would not be necessary in the first place if Solid actually exposed the mountedFrom property we use here. It clearly has all the necessary information in its fstab backend, it's just not accessible from, heh, StorageAccess.

@dfaure @nicolasfella

Merge request reports