Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KIO
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 5
    • Issues 5
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 65
    • Merge requests 65
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KIO
  • Merge requests
  • !534

KCoreDirLister: un-anchor the regex pattern in setFilter()

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Ahmad Samir requested to merge work/ahmad/kcoredirlister-filter into master Aug 07, 2021
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 3

QRegularExpression::wildcardToRegularExpression() by default returns an anchored pattern, which means that if you search for e.g. copyjob, it'll only match if you search for exactly "copyjob.cpp", this can be seen in the "Filesystem Browser" plugin in Kate, that plugin uses KDirOperator to show a filesystem representation and has a search box.

This bug was "hidden" when I was fixing my QRegularExpression::wildcardToRegularExpression() ports some time ago, because I was testing with KFileWidget which changes the fitler string into 'filter', so that worked (see KFileWidgetPrivate::slotFilterChanged()).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/ahmad/kcoredirlister-filter