Skip to content

CopyJob: handle the no-op case of symlinks on FAT partitions

Ahmad Samir requested to merge work/ahmad/fat32-again into master

This copies some code from file_unix (see commit c27196ac) to CopyJob, since the latter is a more central place, we can catch more symlink operations.

And as noted by dfaure in the MR, the code in file_unix is still needed for the use case of apps using FileCopyJob directly and not CopyJob.

Split the msdos filesystem related code to a separate method, more readable this way, I hope.

BUG: 442310 FIXED-IN: 5.88

SkipDialog: adapt buttons to more use cases

  • Add a new option to hide the Retry button, for some operations, retry doesn't make sense, e.g. trying to create a symlink on a FAT partition

  • If we have only one item, and the Retry button is hidden, replace Cancel (which would be the only button shown) with OK

Edited by Ahmad Samir

Merge request reports