[knewfilemenu] Bind stat job connection lifetime to dialog, not the whole menu (!664) · Merge requests · Frameworks / KIO

Nicolas Fella requested to merge work/lifetime into master Dec 14, 2021

The stat job is asynchronous so it may end after the dialog is closed and deleted.

In the slot we are accessing children of the dialog which then can lead to a crash

Change the third parameter in the connect to the dialog instead of the menu to automatically disconnect the connection when the dialog is destroyed

Thanks to Harald Sitter for the investigation.

Edited Dec 14, 2021 by Nicolas Fella

[knewfilemenu] Bind stat job connection lifetime to dialog, not the whole menu