KCoreDirLister: general cleanup

Remove some old commented out code

Use STL algorithms where applicable

Modernise for loops

Make code more readable

Prevent Qt containers detaching

Use STL-style iterators, and for loops