Skip to content

[KUrlNavigatorToggleButton] Load accept icon on demand

Kai Uwe Broulik requested to merge work/kbroulik/kurlnavtoggle-icon-lazyload into master

There's no need to load that icon until we actually want to start editing the address bar.

This uncovered a bug in the size calculation on high-dpi where the QPixmap::width() returns device pixels whereas the sizeHint is supposed to be in logical pixels. By returning the hardcoded value, we ensure the physical size is scaled correctly.

I just thought the button was meant to look like this 😄

Screenshot_20220718_194618

1x scaling | 2x scaling before | 2x scaling after

Merge request reports