Skip to content

Improve PageRow code

Matej Starc requested to merge sporknife/kirigami:work/sporknife/swat-the-mosquito into master

Clean up PageRow's code and make methods more strict. Add type checks, remove unnecessary identifiers, and add strict checks when a parameter is a page/array of pages.

  • The rules are:
  • a page must always be an instance of QtQuick Templates Page.
  • a page must not be already present in the view.
  • either the array size of pages and properties must match, or properties parameter must be empty or set to null.
  • if any of the above rules are broken, it will generate a trace and immediately return null.

Signed-off-by: Matej Starc matej.starc@protonmail.com

Edited by Matej Starc

Merge request reports