Skip to content

pushDialogLayer: don't potentiall override explicitly defined properties

Jack Hill requested to merge jackh/kirigami:work/jackh/pagerow-pushdialoglayer into master

If a user writes e.g. pushDialogLayer(page, {}, {flags: undefined) then we should let QQmlComponent notify the error instead of silently assigning the default value.

amends 5700b623

P.S. I did try Object.hasOwn(windowProperties, "...") and windowProperties.hasOwn("...") but both of them resulted in the errors

TypeError: Property 'hasOwn' of object function Object() { [native code] } is not a function

and

TypeError: Property 'hasOwn' of object [object Object] is not a function

respectively. I guess the QML engine does not support this function yet?

Edited by Jack Hill

Merge request reports