Skip to content

Dialog: fix multiple binding loops (again)

Akseli Lahtinen requested to merge work/akselmo/dialog-fix-binding-loops into master

This was reverted because it caused regressions right before tagging new Kirigami version. Here is the same patch.

To me it looks like the regressions are caused because we're relying on this binding loop bug being there, which this patch fixes. See plasma/plasma-workspace!4784 (comment 1045933)

I believe we should fix this binding loop bug and comb through all our dialogs and see if there's any others that rely on it.

There was multiple bindingloops:

  • widthHint.value
  • calculatedImplicitWidth
  • calculatedImplicitHeight

For example calculatedImplicitWidth was assigning contentItem.width to contentItem.implicitWidth, which never should be done.

The widthHint was basically looping on itself, but the same result could be done with less calculations.

Merge request reports