Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Kirigami
Kirigami
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 7
    • Issues 7
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 14
    • Merge Requests 14
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Frameworks
  • KirigamiKirigami
  • Merge Requests
  • !170

Open
Opened Nov 17, 2020 by Nate Graham@ngraham🔩Developer
  • Report abuse
Report abuse

Fix PageRowGlobalToolBarUI binding loop

  • Overview 13
  • Commits 1
  • Changes 1

We don't need to set the maximum width to 0 if it has no children because this happens implicitly anyway.

This fixes the following warning which appears in the console for all apps using an ActionToolBar:

file:///home/nate/kde/usr/lib64/qml/org/kde/kirigami.2/private/globaltoolbar/PageRowGlobalToolBarUI.qml:65:9: QML RowLayout: Binding loop detected for property "maximumWidth"

Tested in Discover, System Monitor and Kirigami Gallery's ActionToolbar page. No regressions found. Please test some more though.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: frameworks/kirigami!170
Source branch: fix-PageRowGlobalToolBarUI-binding-loop