Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Kirigami Kirigami
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 25
    • Issues 25
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 50
    • Merge requests 50
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KirigamiKirigami
  • Merge requests
  • !283

Add KDE Store avatar and profile links to AboutPage

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dan Leinir Turthra Jensen requested to merge leinir/kirigami:add-store-avatar-to-about into master Apr 26, 2021
  • Overview 10
  • Commits 2
  • Pipelines 2
  • Changes 1

With the introduction of the direct-link avatar endpoint on the KDE Store, we are finally able to make use of the ocsUsername information. We were able to also do this for profile links in the past, but with the avatar endpoint there, we can now do both of them.

Also further fixes a couple of warnings when using the data structure described in the AboutPage's documentation (rather than a KAboutData instance)

Without this change:

image

With this change:

image

Edited Apr 28, 2021 by Dan Leinir Turthra Jensen
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: add-store-avatar-to-about