Skip to content

OverlaySheet: Modify anchors on tall headers imperatively

Ismael Asensio requested to merge work/iasensio/fix_tallheader into master

When the property tallHeader changes, we need to apply the changes to the anchors imperatively.

This way we can control the order and first disable an anchor point before setting the new one, to prevent the icon from grow unexpectedly.

BEFORE AFTER
tallHeader_before tallHeader_after

To trigger a very noticeable case one needs to:

  • Set the font size to Noto Sans 11pt
  • Launch the latest plasma-pa KCM and test an audio output

But it would potentially happen anywhere with an overlay sheet and a tall header

First commit cleans up whitespaces and reorders the id property so the second one looks nicer on diffs.

Merge request reports

Loading