Skip to content

Fixes for CheckableListItem

Nate Graham requested to merge ngraham/kirigami:only-conditionally-trigger-action-in-checkablelistitem into master

Two fixes which should not be squash-merged into one commit:

commit 2a1a6918a265db8c62bd55e9dac834dfb8ee6ff6
Author: Nate Graham <nate@kde.org>
Date:   Tue Feb 8 13:00:03 2022 -0700

    CheckableListItem: Reset list item's checked property when checking box
    
    Otherwise they can drift out of sync, which is bad.
    
    CCBUG: 449766
commit 35a45d0c542b20d64503bc1cb008fd5b6f3bd69c
Author: Nate Graham <nate@kde.org>
Date:   Tue Feb 8 12:11:29 2022 -0700

    CheckableListItem: Only conditionally trigger action when checked
    
    The list item might not have an action, so we shouldn't unconditionally
    trigger it when the checkbox is checked.
Edited by Nate Graham

Merge request reports