Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Kirigami Kirigami
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 20
    • Issues 20
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 31
    • Merge requests 31
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Frameworks
  • KirigamiKirigami
  • Merge requests
  • !511

Icon: Fix tinting of icons to work as described by AbstractButton.icon

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Rodney Dawes requested to merge dobey/kirigami:icon-tinting into master Mar 10, 2022
  • Overview 42
  • Commits 2
  • Pipelines 9
  • Changes 2

The QQC2 AbstractButton component's icon property states that the icon is tinted unless the color is set to "transparent" so Kirigami should exhibit the same behavior. This removes the heuristic based on icon names ending with the "-symbolic" suffix, and adjusts logic to match Qt documentation for the icon property.

In particular, this fixes an issue where Kirigami does not apply the tint to icons loaded from qrc:// or directly in the filesystem, when using the qqc2-breeze-style with QML applications.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: icon-tinting