Skip to content

Use a C++ implementation for ActionToolBar

Arjen Hiemstra requested to merge work/ahiemstra/actiontoolbar_native into master

This replaces RowLayout and ActionToolBarLayoutDetails with a custom C++ implementation. The goal here is to make things faster, profiling shows that the current implementation of ActionToolBar easily takes at least 80ms to be created when used in Cards for example, which is the majority of time it takes to create those. To achieve this, the new ToolBarLayout contains several tricks to reduce creation time.

Work in progress because:

  • Rendering bug in Kirigami Gallery that needs to be fixed.
  • RTL is not handled currently.
  • Need to rework PrivateActionToolButton so it is faster to create.
  • Need to remove all traces of the old implementation.
  • Needs more testing.
Edited by Arjen Hiemstra

Merge request reports