Skip to content

WheelHandler: Fix scrolling over ScrollBars on ScrollablePage

ivan tkachenko requested to merge work/ratijas/scroll into master

Code didn't handle re-parenting of Flickable to a ScrollView, which occurs in ScrollablePage by design. This prevented scrolling over scrollbars in such prominent places as list of System Settings modules or content pane of Discover.

This solution handles re-parenting as well re-assigning either of the two scrollbars via attached properties. The only precondition is that ScrollBar attached object should exist before the target is set, so that we have something to subscribe to.

BUG: 438526

other changes

  1. ScrollablePage: Drop extra rounding code

Not required ever since 8b803828 commit which removed division of units in halves and quarters.

  1. ScrollablePage: Enhance code style
Edited by ivan tkachenko

Merge request reports