Skip to content

Fix some Clazy and switch handling warnings.

Michael Pyne requested to merge work/clazy-warnings-2022-07 into master
  • 2 warnings are generated by g++ in KWidgetJobTracker, due to a KJob::UnitsCount in the KJob::Unit enum. Since this is internal to KJob there's nothing for us to do with it but I'd rather give it an empty handler than add a catch-all default: as that would mask future warnings.
  • 2 warnings are generated by clazy in the autotests about a missing 'emit' from a Qt signal. Fixed by adding Q_EMIT.
  • 1 warning is generated by clazy in KUiServerV2 about an unused trivial QVariant. It looks like this was meant to be used in the next line but then got inlined directly without going back to remove the QVariant.

1 warning remains relating to the deprecated __kjobwidgets_d_do_not_use but that will take care of itself by KF6.

Merge request reports