Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
K
KNewStuff
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 3
    • Merge Requests 3
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Frameworks
  • KNewStuff
  • Merge Requests
  • !101

Merged
Opened Feb 02, 2021 by Dan Leinir Turthra Jensen@leinir🌈Developer

Refactor the KNSQuick Page header and footer for Kirigami-ness

  • Overview 20
  • Commits 8
  • Changes 3

This removes the custom header implementation used on KNSQuick's Page component, which was originally implemented because Kirigami did not at the time support the granularity of control needed to do the stuff we wanted to be able to do. Now that this has changed, it was time to do a refactor and move the things into context actions that make sense to move there (which, essentially, is everything but the category selection, since that one is more type dependent, and arguably a part of the content of the page).

A dialog showing the Page, showing Wallpapers, with these changes: image

The same dialog minus the changes: image

The comic plasmoid feed view, which has no categories looks like this: image

Edited Feb 04, 2021 by Dan Leinir Turthra Jensen
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: frameworks/knewstuff!101
Source branch: refactor-knsquick-page-header-and-footer