Skip to content

Put NewStuff.DialogContent's handle into the global toolbar

Dan Leinir Turthra Jensen requested to merge leinir/knewstuff:master into master

Without this patch, the dialog's bottom is covered by the drawer's handle, which makes it awkward to get to specifically the close button (but also it just looks very strange). So, using Kirigami's nice, new canContainHandles property on the global toolbar, we put the handle up there instead. It also looks nicer, which is... nice.

Desktop shots of mobile mode (where this problem shows up) - without this patch:

image

With this patch:

image

(note these screenshots show an item with categories - without categories it overlaps the close button)

Edited by Dan Leinir Turthra Jensen

Merge request reports