Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KNewStuff
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KNewStuff
  • Merge requests
  • !83

Add a dptr to Cache, and move the throttle timer there to fix crash

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dan Leinir Turthra Jensen requested to merge leinir/knewstuff:dptr-cache-and-fix-throttle-timer into master Dec 10, 2020
  • Overview 3
  • Commits 2
  • Pipelines 0
  • Changes 2

Previously, the throttle timer was a raw static, but it was also a parented qobject, which means that when the cache was deleted, so was the timer, but the variable was not reset. Consequently, things would crash left and right later on. So, to alleviate this, and hopefully avoid future issues, introduce a dptr, stick the timer there, and move the logic to that private class as well.

BUG:429442

FIXED-IN:5.78

Edited Dec 11, 2020 by Dan Leinir Turthra Jensen
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dptr-cache-and-fix-throttle-timer