Skip to content

Clean up KNotifyImage and KNotifyConfig

Kai Uwe Broulik requested to merge work/kbroulik/cleanup-notifyconfig into master

Remove KNotifyImage

There are no known users.

KNotifyConfig: Turn it into a proper class

Especially since it is exported, turn it into a proper class with a private part so we can extend it in the future, and generally have a nicer API to work with.

Warn when there is no relevant notifyrc

In case you mistyped or forgot to set the component name or event id, we would just silently drop the notification, leaving you wonder what's going on.

At least print a warning on console when this happens so you know that the notification itself is at least being triggered.

@nicolasfella

I don’t know how many hours were wasted over the years by KNotification not telling you when you messed up the notifyrc stuff...

Edited by Kai Uwe Broulik

Merge request reports