Skip to content

Deprecate AbstractRunner::dataEngine(...)

KDevelop only recently switched to reuse the kdevelopsessions dataengine in the KRunner plugin (see kdevelop/kdevelop!136 (merged)).

And when I commented on the MR with

Not sure about the future of DataEngines, but as long as that concept and the API has not been officially deprecated, your patch makes sense to me (and in the DataEngine-less future simply things coould be turned into a custom shared library).

we did not foresee the plan to officially abandon DataEngines (https://phabricator.kde.org/T13315) a few days later :)

So to prevent others from doing the same step in the anti-future direction, let's tag the dataEngine access API as deprecated.

From what lxr.kde.org hinted me, there are only 2 users of that method currently, the KDevelop session runner and the dict runner from kdeplasma-addons. For KDevelop I locally have already a patch Update: KDevelop just got ported away by me from it: kdevelop/kdevelop@f9655d4a. For the dict runner I have to leave it to someone else.

@broulik @davidedmundson @alex

Edited by Friedrich W. H. Kossebau

Merge request reports