Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KRunner
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KRunner
  • Merge requests
  • !48

[DBus Runner] Add support for custom pixmap icons for results

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kai Uwe Broulik requested to merge work/kbroulik/remoteimage into master Dec 13, 2020
  • Overview 13
  • Commits 1
  • Pipelines 0
  • Changes 4

Using the same format as notifications


@fvogt @davidedmundson @alex @vkrause

There seems to be some kind of mismatch in formats. In KNotification ImageConverter::variantForImage it converts it to Format_RGBA8888 but in Notification plasmoid it does Format_ARGB32. It works in KNotification but somehow I find this a bit odd.

Also, ideally i'd be able to send multiple icons at different sizes/scales, but imho we'd rather have the relevant KRuner view (e.g. Kickoff with lage icons or KRunner with small icons) tell the runner about what icons size and scale it wants. But of course, icon names are preferred, and this is just for custom stuff, like favicons in tabsrunner, which are only exposed to us as one size by the browser anyway.

Edited Dec 13, 2020 by Kai Uwe Broulik
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/kbroulik/remoteimage