Skip to content

KSycocaDict: don't inherit from containers

Ahmad Samir requested to merge work/ahmad/container-inherit into master

Containers (both Qt and STL) don't have virtual destructors, which could be an issue when trying to delete an object of a derived class via a pointer to the base class.

Instead use a container member. KSycocaDictStringList had delete'ed copy constructor and copy assignment operators, adding to that those since sring_entry objects are owned by KSycocaDictPrivate::m_stringentries, use a unique_ptr, this has the advantage of making copying no-op.

Merge request reports