Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KTextEditor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KTextEditor
  • Merge requests
  • !135

Don't insert null QActions

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ahmad Samir requested to merge work/ahmad/null-actions into master Apr 12, 2021
  • Overview 3
  • Commits 2
  • Pipelines 0
  • Changes 1

This fixes a warning: QWidget::insertAction: Attempt to insert null action

that was because the undo/redo actions were set to null if the document is readonly, instead just disable them like the rest of the actions when in readonly mode.

Found while working on Ark, which uses katepart to preview text files.

NO_CHANGELOG

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/ahmad/null-actions