Skip to content

Improvements to the sizing / positioning of the completion widget

Waqar Ahmed requested to merge work/completion-wid-size-pos into master

This change tries to fix the jumpyness and jerkiness of the completion widget. Summary of the changes:

  • Do position only once, and after all the sizing. This prevents issues like the completion widget thinking that we are touching the edge of the screen when in reality that is not the case at all
  • Only increase width, no reduction. This is done because when we reduce width, you get a flippy floppy behaviour where on every keystroke, the completion widget first reduces its size and then goes back to normal. To fix this, just ignore all updates where width is less than current. Of course, width is renewed everytime the widget is invoked
  • The last and the most annoying behaviour is when we don't have any "expandable" items in the completion tree for a split second. This results in jerks inside the widget and weird size changes. To fix this, just leave space for the "expanding arrow" always.

Signed-off-by: Waqar Ahmed waqar.17a@gmail.com

Merge request reports