Skip to content
GitLab

Drop icon properties in UI files with Designer's broken normaloff injection

Open Friedrich W. H. Kossebau requested to merge work/kossebau/cleaniconproperties into master

Qt Designer (accidentally) injected "." file names as fallback when setting theme icon names.

<property name="icon">
 <iconset theme="format-text-superscript">
  <normaloff>.</normaloff>.</iconset>
</property>

With theme icon names set, it results in generated code like:

    QIcon icon;
    QString iconThemeName = QString::fromUtf8("format-text-superscript");
    if (QIcon::hasThemeIcon(iconThemeName)) {
        icon = QIcon::fromTheme(iconThemeName);
    } else {
        icon.addFile(QString::fromUtf8("."), QSize(), QIcon::Normal, QIcon::Off);
    }

Such a "." file name is not documented to serve any purpose, just results in failing icon lookup.

For empty string icon properties like

<property name="icon">
 <iconset>
  <normaloff/>
 </iconset>
</property>

it results in generated code that sets a bogus icon:

    QIcon icon;
    icon.addFile(QString::fromUtf8(""), QSize(), QIcon::Normal, QIcon::Off);
    next->setIcon(icon);

For the given UI elements the icons will be replaced in manual code later, with more special code, so the properties can just be dropped.