Skip to content

a11y: Set "Line Height Multiplier" buddy in "Appearance" -> "General" tab, improve tab order in "Appearance" -> "Borders" tab page

Michael Weghorn requested to merge michaelweghorn/ktexteditor:michaelweghorn/a11y_set_buddy_and_improve_tab_order into master

Improve accessibility and general keyboard usability of settings tab pages:

  1. Specify the combobox as buddy of the "Line Height Multiplier" label that's seen in Kate's "Settings" -> "Configure Kate" -> "Appearance" -> "General" tab. This allows using the accelerator to jump to the combobox and also makes sure the label-for/labelled-by relationship get set on the accessibility layer, so the Orca screen reader announces the label as well when the combobox gets focus, so it's clear what this is actually for.

  2. Align the tab order (i.e. the order in which widgets receive focus when moving through the dialog using the Tab key) with the visual order for the tab page shown in Kate's "Settings" -> "Configure Kate" -> "Appearance" -> "Borders" tab page, so the focus doesn't unexpectedly jump around. To achieve that, align the widget order in the .ui file with the visual order on the tab page. This way, the widgets are constructed in the same order as their visual order, and tabbing through the page follows that construction order.

Merge request reports