Skip to content

Port the search interface from QRegExp to QRegularExpression

Ahmad Samir requested to merge work/ahmad/search-qregularexpression into master
  • Remove the kateregexp class:

    • Move isMultiLine() and repairPattern() to kateregexpsearch; merge them into one function
    • Dot '.' character will match any character except a newline by default
  • Explicitly enable QRegularExpression::MultilineOption, for the rationale see the comment at the top of KateRegExpSearch::search()

  • KateCommands::SedReplace::InteractiveSedReplacer::InteractiveSedReplacer() was updated to use QRegularExpression, but not tested

  • Adjust the extended context menu used in the find box:

  • Tweak/extend the relevant unit tests (searchbar_test, regexpsearch_test)

  • All unit tests pass except for these ones (which fail on master too): kateindenttest_testCppstyle (Child aborted) kateindenttest_testPascal (Child aborted) bug313759 (Child aborted)

Merge request reports