Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KTextEditor
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Frameworks
  • KTextEditor
  • Merge requests
  • !7

Port the search interface from QRegExp to QRegularExpression

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ahmad Samir requested to merge work/ahmad/search-qregularexpression into master Jul 29, 2020
  • Overview 15
  • Commits 3
  • Changes 14
  • Remove the kateregexp class:

    • Move isMultiLine() and repairPattern() to kateregexpsearch; merge them into one function
    • Dot '.' character will match any character except a newline by default
  • Explicitly enable QRegularExpression::MultilineOption, for the rationale see the comment at the top of KateRegExpSearch::search()

  • KateCommands::SedReplace::InteractiveSedReplacer::InteractiveSedReplacer() was updated to use QRegularExpression, but not tested

  • Adjust the extended context menu used in the find box:

    • QRegularExpression supports positive/negative fixed-length lookbehind
    • \x.... escape sequences must be wrapped in curly braces if more than two hex digits is used, so it's better to just always wrap \x escape sequencess in curly braces (QRegularExpression upstream recommendation), c.f.:
      • https://phabricator.kde.org/D26123#inline-147157
      • https://perldoc.perl.org/perlre.html
  • Tweak/extend the relevant unit tests (searchbar_test, regexpsearch_test)

  • All unit tests pass except for these ones (which fail on master too): kateindenttest_testCppstyle (Child aborted) kateindenttest_testPascal (Child aborted) bug313759 (Child aborted)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/ahmad/search-qregularexpression