Skip to content

KShortcutsEditor: hide local shortcuts columns when needed

Nate Graham requested to merge ngraham/kxmlgui:hide-local-shortcuts-columns-when-there-are-no-local-shortcuts into master

33339de5 resulted in the global shortcuts columns being automatically hidden when the dialog has no global shortcuts. However it did not do the reverse, which is also possible. For example, KWin effects have only global shortcuts and no local shortcuts (local shortcuts don't even make sense there).

In such a case, we should hide the local shortcuts columns and only show the global ones.

BUG: 474570 FIXED-IN: 6.0

@ahmadsamir

Test plan:

  • Look in settings window for KWin effects -> see no local shortcuts columns anymore
  • Look in keyboard shortcuts config window for Kate, Konsole, and Elisa -> see no regressions there, i.e. only local shortcuts columns

Merge request reports