Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • K KXMLGUI
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • KXMLGUI
  • Merge requests
  • !57

Remove the Attica requirement by using the store's new links

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dan Leinir Turthra Jensen requested to merge leinir/kxmlgui:remove-attica-requirement into master Apr 30, 2021
  • Overview 19
  • Commits 8
  • Pipelines 0
  • Changes 10

This removes patch removes the hard requirement on Attica, but retains most of the functionality (minus the location magic and multiple links), by using the KDE Store's new abilities to link to profiles and avatars using the username of a person.

This adds a checkbox (similar to the one found in Kirigami.AboutPage as of kirigami!283 (merged)) which defaults to off, so we never go online to fetch stuff unless the user explicitly allows for this to happen. Future work might be to store this checkbox' state, perhaps in a global fashion.

An about dialog without this patch:

image

The same about dialog, with the checkbox checked:

The checkbox defaults to off, and the look is as above.

image

This is for the the https://phabricator.kde.org/T12198 task

Edited May 04, 2021 by Dan Leinir Turthra Jensen
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: remove-attica-requirement