Skip to content

Include only needed headers instead of QtDBus module header

Using QtDBus module header, while being convenient, comes with a cost, even with a small library like QtDBus. And it might be a internal choice for a library, but the public header "ModemManagerQt/generictypes.h" also was using #include <QtDBus>, thus forcing any consumers into this.

I sadly do not have a build setup of Plasma6, so cannot test whether the change of the transitive includes might break someting in plasma-dialer, spacebar, plasma-mobile or plasma-nm. ModemManagerQt API's use of QtDBus types should be covered though by its own includes, as inheritance and inline methods require non-forward declarations in the own public headers, by what I checked.

So please someone with Plasma stakes review (and merge) this and help out with any missing includes this exposes in the consumers.

Managed to do test builds, found two projects that needed some small preparation and did MRs:

Any other projects I found with lxr.kde.org kept building against ModemManagerQt with this patch.

No backport plans, due to these SC issues.

Edited by Friedrich W. H. Kossebau

Merge request reports

Loading