Skip to content

SpinBox: Repair hovering, and improve RTL

SpinBox: Reformat QML for better code style and clarity

SpinBox: Let hover events propagate through TextField to the control

Otherwise, up/down indicators won't update their hovered states, and will be displayed incorrectly.

BUG: 459004

SpinBox: Reset activeSubControls when neither of indicators are active

Otherwise, an indicator remains in an active state even after being released and unhovered.

BUG: 459004

SpinBox: Remove assignment which is never read

There's a opt->subControls = QStyle::SC_All assignment below, which makes sense, as we always want to draw every part of a SpinBox, including up/down indicators.

SpinBox: Avoid explicit horizontalAlignment in TextField for better RTL

TextField is capable of detecting when it should use right alignment for RTL text, otherwise it is already left-aligned by default.

SpinBox: Flip left/right padding for styles with indicators on the sides

This is completely untestable with stock Breeze theme, but according to PlasmaComponents (e.g. in Panel's Edit Mode) and Qt's Basic QQC2 style the "down" indicator is supposed to be on the left and "up" is on the right.


Also, I tried hard to rewrite __lPadding/__rPadding bindings so they include actual gap between an indicator and control (i.e. control.width - up.indicator.x instead of simply up.indicator.width), but I just couldn't manage it without drowning in binding loops :-\

Merge request reports

Loading