Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Q QQC2 Desktop Style
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • QQC2 Desktop Style
  • Merge requests
  • !223

ScrollView: Remove custom background-colored rectangle

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged ivan tkachenko requested to merge work/ratijas/scrollview-without-rect into master Jan 29, 2023
  • Overview 3
  • Commits 2
  • Pipelines 3
  • Changes 2

It was getting in the way of native styled background. In particular, it was turning rounded Breeze corners into visually broken "korners".

Before After
Before After

There's still some overlapping from delegates: neither their background nor content is masked with a scrollview frame, so they are only being clipped by the rectangle bounds of a scrollview as an Item. But imho this is already an improvement, and I didn't spot any regressions in any of default themes (Breeze, Oxygen, Fusion, MS9x) and light/dark color schemes. Checked all System Settings pages with cherry-picked KF5 patch.

CC @teams/vdg

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/ratijas/scrollview-without-rect