Skip to content

Draft: [WIP/RFC] Give the user options not to load plugins and more info about spellers

loh tar requested to merge work/customize-plugin-load into master
  • Split settings dialog into tabs
  • Show info about available dictionaries per speller
  • Give hints how to handle problems
  • Move no-backend warning to plugin tab, tab is switched to if needed
  • Show some info labels only when useful

This patch supersede !52 (merged)

BUG: 398247 Spellchecking KCM should give more info on what "backend" is missing
BUG: 333067 Sonnet setting dialog doesn't show up if there's no dictionary
(not exact but now is a hint about missing dictionaries)
BUG: 433154 Sonnet tries to load some Hebrew dictionary on an English-only system
BUG: 420469 Alway report init failed for sonnet and Hspell
BUG: 424734 Unnecessary console messages: "Sonnet: Unable to load plugin ...."

Current state is that everything (seems to) work as designed with the exception that saving changes is missing :-) but it's not perfect. There is missing that changes only take effect after restart of the application. The loader has no "unload plugin" or "reload config" functionality. That should be fixed in an other patch.

There are some questions and notes in the code to solve. I try to collect them:

  • Is use of tr for translation, OK? I got i18n not working (see comments below)
  • I have added also stuff what looked like "seems to be needed even I don't use it" => these Q_PROPERTY and related. Not idea if the current solution is OK. And if the not used, but added stuff can removed or if these Q_PROPERTY lines can be modified to fit the used code.
  • I have tried to support static builds (without plugins?) too but of course not tested. And I only guessed that e.g. Mac has no plugins.

Here how it looks in Kate

kate-main kate-igno kate-spell

And here a designer preview showing all labels, they will hidden if not useful

speller-page-in-designer

Edited by loh tar

Merge request reports