Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • S Syntax Highlighting Engine
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FrameworksFrameworks
  • Syntax Highlighting Engine
  • Merge requests
  • !472

Use all-upper-case version variable names (KF consistency), also K-prefix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Friedrich W. H. Kossebau requested to merge work/kossebau/alignversionnamepattern into master Apr 06, 2023
  • Overview 1
  • Commits 1
  • Pipelines 2
  • Changes 5

All (but 3 currently) KF modules use UPPERCASE_VERSION pattern for the version macros/variables. So let's be more consistent to allow more writing-by-patters :)

No plan to backport to KF5, as this is a SC-breaking change. IMHO anyone who might want to have code both compatible with KF5 & KF6 would need to do local support for both variants where needed.

And as this macro is used in preprocessor condition usually, at least I know of no way to add deprecation warnings, so preparing things on the KF5 side might not be possible.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/kossebau/alignversionnamepattern