Skip to content
  • Jarek Kobus's avatar
    Get rid of virtual inheritance from ThreadEngineBase · a4071c18
    Jarek Kobus authored
    
    
    The virtual inheritance causes the issue, when adding
    new, non-default constructor to the base ThreadEngineBase
    class. It looks like classes derived from it can't
    use the non-default constructor, even when it's called
    explicilty from the subclass. Instead, the default constructor of the
    ThreadEngineBase class is always required during compilation
    and called on runtime.
    
    In addition, the only sensible use of the virtual inheritance
    is the multiple inheritance, but apparently it looks like
    there is no single class in Qt which would multi inherit from
    the ThreadEngineBase class, so this change shouldn't have any bad
    side effects. This justifies the current lack of info on why it
    was introduced originally ages ago.
    
    Change-Id: I08266e6f6865d938d1b1e4243ef94d2c02c3a886
    Reviewed-by: default avatarLars Knoll <lars.knoll@qt.io>
    a4071c18