From the ecm_add_app_icon documentation:

  The given icons [...] will be added to the executable target whose
  sources are specified by <sources_var> [...]

It will probably fail with the sources_var being defined in the
subdirectory and used for the library. In any way, the new version
is cleaner and therefore preferable in any case.