Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KBlocks KBlocks
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GamesGames
  • KBlocksKBlocks
  • Merge requests
  • !4

Move last piece before game over

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julian Helfferich requested to merge helfferich/kblocks:move_last_piece_before_game_over into master Jan 20, 2021
  • Overview 6
  • Commits 7
  • Pipelines 2
  • Changes 16

I have split up merge request !2 (closed) into smaller pieces. This is part two. In the end, bugs 407244 and 380462 will be fixed.

For the last piece to move, the game actions need to be processed even when the game is over. I have written a unit test (and put the necessary infrastructure into place) to make sure that this is the case.

Indeed, the last piece is moved, but only after the high-score window is closed. The next merge request will make sure that the last piece is moved before the high-score window is shown.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: move_last_piece_before_game_over