Skip to content

Port QRegExp in advancedrename tool

Anjani Kumar requested to merge port-qregexp-extras into gsoc21-qt6-port

QRegExp::setMinimal() can be ported to QRegularExpression::setPatternOptions(QRegularExpression::InvertedGreedinessOption).

Update

The previous version of this patch introduced a regression caught by the test advancedrename_utest. The bug was how QRegExp object itself was being passed around used by the API to extract match groups from the pattern. With QRegularExpression it became necessary to pass the match object, i.e. QRegularExpressionMatch to Rule::parseOperations().

The updated patch now contains:

  • Updated API in advancedrename/common.
  • Implementation of this new API.

Tests now pass.

Edited by Anjani Kumar

Merge request reports

Loading