Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Gwenview Gwenview
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Graphics
  • GwenviewGwenview
  • Merge requests
  • !141

Improve Sorting

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open fabrice SALVAIRE requested to merge fabricesalvaire/gwenview:sorting into master May 01, 2022
  • Overview 13
  • Commits 7
  • Pipelines 2
  • Changes 14

For review...

The purpose of this patch is to fix the sorting in Gwenview.

I believe Geeqie has a better sorting.

Actually, I am annoyed by these behaviours:

  • Gwenview uses the EXIF date when it is available to sort by date. This feature is a mess when we want to sort by modified date. Despite it can make sense, this feature is not documented. A workaround is to remove the EXIF date, but this is cumbersome.
  • Gwenview gets the sorting from a DBUS query when we open a directory using the method MainWindow::setInitialUrl (a click on a directory in the recent places). This is also a silent behaviour, and it ignores/overwrites the actual Gwenview sorting setup. Thus, this is clearly a bug.
  • Gwenview sorting is hidden in the UI menu, and sometimes it is set silently by DBUS.

This patch

  • implements a Date Modified and EXIF sorting
  • implements an Image Dimension sorting
  • add a prefix label to the sorting action to show which sorting is set
  • disable DBUS query to get the sorting of a directory (don't know what to do...)

I am not sure the image dimension code is the most efficient.

CI pipeline failed, but this patch compiles and works as expected.

TODO: this patch need some clean-up... (logging, Emacs, ...)

Edited May 03, 2022 by fabrice SALVAIRE
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: sorting