Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Gwenview Gwenview
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Graphics
  • GwenviewGwenview
  • Merge requests
  • !24

Replace slideshow ServiceMenu by SlideShowFileItemAction

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Méven Car requested to merge meven/gwenview:work/slideshow-action into master Nov 26, 2020
  • Overview 63
  • Commits 14
  • Changes 5

Using a KAbstractFileItemActionPlugin allows to have more control over when actions are shown in context menus.

BUG: 429531

BUG: 430048

FIXED-IN: 21.04

@ngraham @alex

Test plan:

  1. Right click any number of folders with no images in it -> Start a slideshow is not visible

  2. Right click on any number of folder(s) containing at least one image -> Start a slideshow is visible

Same for files.

When the selection contains a mix of folders and files the action is not displayed.

Remaining question: how to remove the old SlideShow Service Menus ?

Edited Dec 07, 2020 by Méven Car
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/slideshow-action