Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Gwenview
Gwenview
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 4
    • Merge Requests 4
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Graphics
  • GwenviewGwenview
  • Merge Requests
  • !36

Merged
Opened Feb 02, 2021 by Madhav Kanbur@abcdjdjContributor

Use Quality level when saving JPEG images

  • Overview 1
  • Commits 1
  • Changes 2

Previously, GwenviewConfig::jPEGQuality() was being used only by updateRawDataFromImage() in jpegcontent.cpp. updateRawDataFromImage() is called only when d->mImage is not null, implying that only "modified" jpeg images get written to disk with the user's set quality level. This patch unconditionally saves jpeg images to disk at the set quality level.

Also, this patch fixes a race condition introduced by merge request !26 (merged). We now wait for the save KJob to finish before restoring the quality level.

Signed-off-by: Madhav Kanbur abcdjdj@gmail.com

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: graphics/gwenview!36
Source branch: jpeg-quality-fix