Skip to content

Show keyboard shortcuts in tooltips only once not twice

Felix Ernst requested to merge (removed):remove_duplicate_shortcuts into master

The tools on the left bar of Kolourpaint show their respective keyboard shortcuts in their tooltips.

There was a change in KDE frameworks (https://commits.kde.org/kxmlgui/ecd7cefd8d4b8ddb15b8e3a3e6e9bd5c55a9c12c) that made it so all tooltips of actions show their keyboard shortcuts in their tooltips by default.

Together this meant that the keyboard shortcut is shown twice. The first commit of this merge request fixes this by removing the Kolourpaint-specific code to show the keyboard shortcut in the tooltip.

BUG: 456888


This merge request also contains a secondary commit that is more of a refactor/cleanup in response to the first commit:

Delete custom kpToolAction class

This commit has no user-visible effect.

This commit deletes the kpToolAction class which is a KolourPaint-
specific subclass of KToggleAction.

kpToolAction used to have the specialised functionality of creating
a custom tooltip that showed the keyboard shortcut but this
functionality was removed in the previous commit because it
became redundant thanks to a frameworks change.

Because of this there is no reason left to keep this subclass
around. Instead its base class KToggleAction is used everywhere.
Edited by Felix Ernst

Merge request reports