Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • KolourPaint KolourPaint
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GraphicsGraphics
  • KolourPaintKolourPaint
  • Merge requests
  • !8

[Rotate Dialog] Use themed rotate (anti)clockwise icons

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kai Uwe Broulik requested to merge work/kbroulik/themed-rotate-icons into master Aug 24, 2021
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Got bothered by the blocky look on highdpi, looks a lot nicer :)

Somehow the Adwaita theme here doesn't load properly.

object-rotate-left and object-rotate-right are part of the FDO icon name spec [1].

Before

Screenshot_20210824_230846

After (Breeze)

Screenshot_20210824_230824

After (Oxygen)

Screenshot_20210824_230801

The check for whether we got a fallback to object-rotate or object (which we don't want here) does not work due to a bug in KIconEngine, cf. https://bugs.kde.org/show_bug.cgi?id=432293 – QIcon::name() always returns whatever you passed in even if the icon you got didn't actually go by that name.

@dfaure @heikobecker @mkoller @teams/vdg

[1] https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html#:~:text=an%20object%20vertically.-,object-rotate-left,-The%20icon%20for

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/kbroulik/themed-rotate-icons