Skip to content

441113 441116 GMic: emergency update for 2.9.8

Amy spark requested to merge lsegovia/krita:work/amyspark/gmic into master

This MR packages an emergency update to our GMic plugin.

Changelog is here: https://github.com/amyspark/gmic/compare/v2.9.8...v2.9.8.1

Mainly, I fixed the two showstoppers from @alvinwong, which stemmed from GMic tampering with QCoreApplication (either via the organization name/domain and application name, or by calling exit(int)). These in turn led me to find additional double-frees and leaks that would happen if using the "apply the last G'Mic filter" option.

Test Plan

Build Krita.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Amy spark

Merge request reports