Skip to content

Android: Support directory operations

Sharaf Zaman requested to merge szaman/krita:sh-zam/android-dir-ops-support into master

Test Plan

  1. All the previous file operations should work like before.
  2. Recorder docker should be capable of creating files in directories other than the default
  3. Animation docker should be able to create frames in directories other than the default
  4. Note: currently, the https://bugs.kde.org/show_bug.cgi?id=427042 is pending. But the fix should be trivial enough after this. I'll push the fix for it pretty soon. (Fixed)
  5. All file directory operations should work properly
  6. A stress test is to change the resource location to some random directory.

Link to unsigned APK: https://drive.google.com/file/d/1UWYnKtKrPPAr_DUSNJjyLCqwdpMe6t2P/view?usp=sharing

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Sharaf Zaman

Merge request reports