Skip to content

Make scrollbar usable with kinetic scrolling enabled

Alvin Wong requested to merge alvinwong/krita:alvin/kinetic-scroll-scrollbar into master

Before this change, when kinetic scrolling is enabled and the scroll bars aren't hidden, trying to drag the scroll bars will trigger kinetic scrolling instead of dragging its handle. This adds some sort of a hack that tracks the cursor entering and leaving the scroll bars to disable the kinetic scrolling while the cursor is over the scroll bars.

Tested on Linux with left click only. Needs further testing to verify that this works on Windows, and with touch/middle click.

Test Plan

  • Enable kinetic scrolling
  • Try using scroll bars on widgets with kinetic scrolling enabled.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • n/a I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports