Skip to content

Fix recorder to use KisFFMpegWrapper for finding FFMpeg

Know Zero requested to merge knowzero/krita:KnowZero/ffmpeg-recorder-and-export-fixes into master

Fix recorder to use KisFFMpegWrapper for finding FFMpeg

The checkFfmpeg function in the recorder was not using the wrapper to detect FFMpeg, this was an oversight and this patch should fix that.

This will also fully fix Bug #441435

Indicate when H264 support is disabled in FFMpeg

A common mistake made by users is downloading or using an FFMpeg version that has H264 disabled, then trying to create an MP4/MKV only to get an "unknown error". Until the render UI is overhauled, this is an interim solution to make it clearer for users that their FFMpeg does not support MP4/MKV by putting "(MP4/MKV UNSUPPORTED)" next to the version.

Also makes it more clear when FFMpeg is not found.

Test Plan

Recorder fix: (Preferably if done on windows using a snapshot build as it would show it working properly now)

  1. Open the recorder docker
  2. Go to export and click the folder icon to select the FFMpeg you wish to use(If you have one already selected, that is fine too as both run the checkFfmpeg function).

For the h264 check:

  1. Download an FFMpeg without H264 support, such as most of the LGPL builds
  2. Create an animation
  3. File->Render Animation
  4. click the folder icon for FFMpeg and select the LGPL build, the version should now also show "(MP4/MKV UNSUPPORTED)"

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports